-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project ARES - Resurrection #3298
Conversation
The linter does not like the order of includes. Should be in alphabetical order but it might be inconsistent with symbols.
|
Noticed. It doesn't like folders, puts them after non-foldered stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing else sticks out to me just reading the code.
85ff454
to
4e1aafd
Compare
b93212a
to
95cfffc
Compare
95cfffc
to
8af0ddb
Compare
Yeah, I am addressing it in #3305 so I wouldn't worry about it here. Only if your ares structures still are showing up as problems. |
224b6fa
to
1c7c6da
Compare
Generally I really like this, especially being able to go back and review the logs. However I'm not too sure about the ARES Core remodel and the way it janks the (less than a week old) IO area. Am happy to contribute some designs if you would like. |
Co-authored-by: harryob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get out of my tracker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprites are pretty straightforward and look good to me
approved!
# About the pull request Further to #3298 develops the Apollo Maintenance Controller to be functional properly. At present it only functions for maintenance tickets, but will eventually allow for proper use of access tickets, and remote access of the console by working joes (hopefully) <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: add: Adds functional maintenance ticket control to the Apollo Console add: Adds a unique ID system for each ticket. Credit to Ben10083 for the idea. add: Adds procs for vents to spew gas within a radius. Not currently usable without proccall. code: Starts work on Access Tickets. code: START of contribs from Ben10083 add: ARES now announces when Bioscan fails. code: new procs to see if ARES can talk, or log something. Bioscan proc renamed for consistency. admin: Admins can now force an ARES announcement or communication if subsystem is offline. add: new emergency protocol from ARES; call General Quarters, which sets the ship to immediate Red Alert. add: New APOLLO maintenance ticket categories; Janitorial and Support. Fire now a priority ticket qol: Claimed APOLLO tickets can be unclaimed qol: APOLLO tickets can be rejected/completed if unclaimed by any Working Joe code: END of contribs from Ben10083 /:cl: --------- Co-authored-by: Ben10083 <[email protected]> Co-authored-by: Ben <[email protected]> Co-authored-by: harryob <[email protected]>
About the pull request
Overhauls ARES and makes it actually feel like a part of the ship and not a square box.
Adds individual processors for different ARES systems that interact with oneanother to produce the same effects as we normally have.
Bioscans require the bioscan processor to be functional, however will not broadcast if the interface processor is not functioning.
The interface processor handles ARES communications (excluding Apollo) and is chiefly responsible for logging things to the ARES Console. This console can be used to review logs of all ARES' messages/announcements, Bioscans, the Apollo Link logs etc.
Explain why it's good for the game
Adds a little immersion and use for ARES.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
add: Added an admin button for an ARES bioscan. Slightly refactored how Bioscans trigger for marines, relying on an ARES processor.
add: Added individual proccessors for ARES systems. These are WIP and will eventually have damage and repair interactions.
add: Added an ARES interaction console in the AI Core room, which holds logs for most ARES functions.
add: Added the ability for ARES console to call ERT or Distress.
add: Added motion triggers in ARES core and shipside comms that send alerts over Apollo.
add: Added a 1to1 conversation feature between ARES and users of the interface console.
add: Added preset open versions of blended poddoors.
add: Added a console for directing Working Joes. This is largely WIP for future PR(s).
add: Added subtypes of air pipes that don't explode on hijack, used these in ARES core.
maptweak: Remodelled ARES Core onto a fake-z, and added the new processors.
fix: door_control buttons now respect being indestructable when processing explosions.
maptweak: Fixed the M39s overflowing in brig armory due to use of landmarks.
/:cl: